Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road connections for specials always start on land #70682

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jan 5, 2024

Summary

Bugfixes "Road connections for specials always start on land"

Purpose of change

Workaround for #22133, a neater solution would still be nice

Describe the solution

Describe alternatives you've considered

Testing

Teled along a winding river from my starting OM to (87, 1978, 0) without finding a single borked bridge before getting bored

Additional context

While this appears to add quite a mess to specials.json for a workaround the whole lot can be removed with a single regex replace of
,\s+{.*"point":\s+[\s+-?[0-9]+,\s+-?[0-9]+,\s-?[0-9]+\s+],\s+"locations":\s+[\s+"land",\s+"road"\s+]\s+}
with notepad++ for example

Can be removed quickly using a regex replace of
,\s+\{.*"point":\s+\[\s+-?[0-9]+,\s+-?[0-9]+,\s-?[0-9]+\s+\],\s+"locations":\s+\[\s+"land",\s+"road"\s+\]\s+\}
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 5, 2024
@Procyonae Procyonae marked this pull request as ready for review January 6, 2024 11:52
@Procyonae Procyonae force-pushed the RoadConnectionsStartOnLand branch from 60d6550 to 1bca8cc Compare January 6, 2024 11:54
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 6, 2024
@Maleclypse Maleclypse merged commit 42e59f3 into CleverRaven:master Jan 9, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants