Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Edit spell UI a bit for psionics #70638

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[MoM] Edit spell UI a bit for psionics"

Purpose of change

Every single MoM power "does not require hands" and it's a little misleading that they all "requires concentration" when that's not what concentration means under the MoM paradigm.

Describe the solution

Edit the enumerate_spell_data function. Now the first this is that it checks for the PSIONIC flag and, if it finds it, says "is a psionic power." Since all MoM powers are affected by Focus, "requires concentration" is now only printed on spells (i.e. without the PSIONIC flag), same with "does not require hands"

I also changed the display for NO_PROJECTILE to "can be channeled through walls" (from cast). I can't force players to use terminology that differentiates psionics from spells but I can make the UI do it!

Describe alternatives you've considered

Testing

Changes show in-game.

Additional context

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Jan 4, 2024
@github-actions github-actions bot requested a review from KorGgenT January 4, 2024 04:53
@github-actions github-actions bot added the Mods Issues related to mods or modding label Jan 4, 2024
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 4, 2024
Standing-Storm and others added 4 commits January 3, 2024 22:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Jan 4, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 4, 2024
@Maleclypse Maleclypse merged commit 99301a4 into CleverRaven:master Jan 4, 2024
25 checks passed
@Standing-Storm Standing-Storm deleted the is_psionic branch January 5, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants