Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor cramped space errors #70607

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Conversation

worm-girl
Copy link
Contributor

@worm-girl worm-girl commented Jan 2, 2024

Summary

Bugfixes "Fix minor cramped space errors"

Purpose of change

#70560 accidentally reintroduced #70389 , this re-fixes it.

Describe the solution

Delete the early returns, also remove a small piece of unused code that was left in.

Describe alternatives you've considered

N/A

Testing

Compiled and slept in a cramped space, the game did not crash. I woke up instead of sleeping forever. Cramped space debuff fell off when I exited the vehicle as intended.

Additional context

Thanks to @BrettDong and @inogenous for spotting the errors.

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 2, 2024
src/character.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 3, 2024
@Fris0uman Fris0uman merged commit 2b18060 into CleverRaven:master Jan 3, 2024
25 checks passed
kevingranade added a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants