Fix impassable broken vehicle parts

[worm-girl]

Summary

Bugfixes "Fix impassable broken vehicle parts"

Purpose of change

fixes #70555
fixes #70564

Vehicle part passability wasn't properly checking for whether certain parts were or were not broken when deciding whether to see if you could move through them. This was my fault!

Describe the solution

The check for free cargo space is now bypassed if the part is broken (it can't hold anything if it's broken and shouldn't obstruct anyone based on its contents). The check for cargo_passable also still runs if the part is broken.

Also adjusts some vehicle part sizes that I missed.

Describe alternatives you've considered

We could do more in-depth checks on broken parts. Right now they just get a pass as the game sets their capacity to 0 ml which skips the passability check. This allows IE a hulk to smash its way into a car without having to completely delete the tile, though said hulk will still get the cramped space debuff since it's huge. The bucket seat is no longer obstructing the space, but you're still cramming yourself in a too-small vehicle. IMO that makes enough sense that we shouldn't worry about it, but it could be made more granular in the future if desired.

Testing

• Stepped on an empty cargo tile.
• Stepped on a broken cargo tile.
• Put a body in a cargo tile, and became unable to step there.
• Stepped on a broken door.
• Stepped on a working door.
• Spawned a zombie and had it do the same.
• Checked that the special case penalties for huge creatures being in vehicles still applied properly in broken parts.
• Checked that inflatable boats are usable again.

Additional context

[prharvey]

Slightly unrelated to this change, but the cramped_space effect is applied incorrectly for monsters. You're doing it in monster::will_move_to which is only a check if a monster should move there, but doesn't actually move the monster. It should be done in monster::move_to.

Also note that it's probably not worth spending a lot of time on this, since I'm rewriting the pathfinder anyways: #70274 - I still need to integrate your changes into it.

[worm-girl]

Slightly unrelated to this change, but the cramped_space effect is applied incorrectly for monsters. You're doing it in monster::will_move_to which is only a check if a monster should move there, but doesn't actually move the monster. It should be done in monster::move_to.

Also note that it's probably not worth spending a lot of time on this, since I'm rewriting the pathfinder anyways: #70274 - I still need to integrate your changes into it.

Thanks! I moved it to move_to and it seems like it's working properly.

[BrettDong]

The condition of the if block at line 10943 becomes always false after your change at this line, right?

Line 10943:

if( !has_effect( effect_cramped_space ) ) {
    add_effect( effect_cramped_space, 2_turns, true );
}

[worm-girl]

Oh, it looks like you're right. That shouldn't cause any problems but it should be removed.

[inogenous]

These early returns were the cause of #70389 before, which was fixed in #70409 . In this change, the return-statements here and on line 10956 are added back. Do you know if this change accidentally re-introduces #70389 again now if you sleep in a cramped space in a vehicle?

[worm-girl]

I don't, and they probably do. I didn't realize I was re-introducing the bug.