Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EoC ability to remove effect from specific body part #70149

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

furran
Copy link
Contributor

@furran furran commented Dec 11, 2023

Summary

Features "Add optional field "target_part" to EoC character effect 'remove_effect'"

Purpose of change

Adds EoC ability to remove effect from a specific body part, similar to how u_add_effect/npc_add_effect works.

Closes #70131

Describe the solution

Updated set_remove_effect and necessary functions to allow for selection of a body part. Just like it works in set_add_effect.
Also updated docs.

Describe alternatives you've considered

None

Testing

Drop this json file into data/effects_on_condition: furran_tests.json

  1. Get in game. Give yourself the spells in furran_tests.json.
  2. Use Test Bleed on yourself, check your wounds. Your head, torso and arms should be bleeding.
  3. Use Test Cure Head on yourself. Check your wounds again. Only your head should have stopped bleeding.
  4. Repeat 2 and 3 but instead target a debug monster.

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 11, 2023
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Dec 11, 2023
@furran furran marked this pull request as ready for review December 11, 2023 17:44
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 11, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2023
@furran furran marked this pull request as draft December 12, 2023 15:15
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2023
@furran furran marked this pull request as ready for review December 12, 2023 19:16
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 13, 2023
@Maleclypse Maleclypse merged commit 0fd10a7 into CleverRaven:master Dec 13, 2023
21 of 24 checks passed
@furran furran deleted the lose_effect_bp branch December 17, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EoC ability to remove effect from a specific body part
2 participants