Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error "No such parameter 'den_palette'" being thrown during build checks randomly #70197

Closed
furran opened this issue Dec 14, 2023 · 3 comments
Closed
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@furran
Copy link
Contributor

furran commented Dec 14, 2023

Describe the bug

I've noticed that recently ( the last few days ) new pull requests have been failing checks because of the following error:

(all_mods)=> Backtrace emission took 2 seconds.
(all_mods)=> (continued from above) ERROR : src/mapgendata.h:244 [Result mapgendata::get_arg(const std::string &) const [Result = string_id<mapgen_palette>]] No such parameter "den_palette"
(all_mods)=> [ Previous repeated 61 times ]
(all_mods)=> 11:37:19.079 ERROR : src/mapgendata.h:244 [Result mapgendata::get_arg(const std::string &) const [Result = string_id<mapgen_palette>]] No such parameter "den_palette"

This is not a failed test, it's a test throwing an error.

The culprit seems to be the trail.json file introduced in #67470, as it is the only place I could find related to mapgen that had "den_palette" and it matches the timeline I felt it started happening.

I don't really know how to fix this properly.

Attach save file

N/A

Steps to reproduce

It is seemingly random. But chances are if you created pull requests recently, you have seen this error.

Expected behavior

The mapgen tests do not throw errors

Screenshots

No response

Versions and configuration

N/A

Additional context

Some PRs with this error in their checks for anyone who wants to check: #70163 #70184 #70149 #70120

@furran furran added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 14, 2023
@physics-enthusiast
Copy link
Contributor

Seeing an error about den_palette thrown in gameplay occasionally as well, although I don't remember the specific message and can't reproduce whatever is causing it.

@GoLoT
Copy link
Contributor

GoLoT commented Dec 14, 2023

I saw this too while loading a new overmap tile in a new world (created 2 days ago on latest experimental at the time). The error message was the same as in the tests and it showed up multiple times per overmap tile. I only had it happen twice so far but I didn't continue exploring.

@BrettDong BrettDong added (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Dec 15, 2023
@Maleclypse
Copy link
Member

Fixed by #70248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

5 participants