Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn FOV_3D on by default #70057

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

I think it's in a good shape to make it on by default for now

Describe the solution

Switch the toggle to true
Also update the option description a bit

Issues

original PR was #69935, but it was found it breaks some tests, so it was reverted in #69940

Error: (~[slow] ~[.],starting_items)=>   false
(~[slow] ~[.],starting_items)=> with message:
(~[slow] ~[.],starting_items)=>   activity.id() := string_id( "ACT_TENT_DECONSTRUCT" )
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> activity_interruption_by_distractions
(~[slow] ~[.],starting_items)=>   ACT_TRY_SLEEP enemy nearby, but no line of sight
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> ../tests/player_activities_test.cpp:1826
(~[slow] ~[.],starting_items)=> ...............................................................................
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> ../tests/player_activities_test.cpp:1833: FAILED:
(~[slow] ~[.],starting_items)=>   REQUIRE( !dummy.sees( zombie ) )
(~[slow] ~[.],starting_items)=> with expansion:
Error: (~[slow] ~[.],starting_items)=>   false
(~[slow] ~[.],starting_items)=> with message:
(~[slow] ~[.],starting_items)=>   activity.id() := string_id( "ACT_TRY_SLEEP" )

Until fixed, it is not safe to merge this PR

Additional context

Revert "Revert "turn FOV_3D on by default""

@GuardianDll GuardianDll changed the title Revert "Revert "turn FOV_3D on by default"" turn FOV_3D on by default Dec 7, 2023
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 7, 2023
@PatrikLundell
Copy link
Contributor

I don't think this should be done before #69053 has been fixed (killed by the stale-bot, but that won't make the bug go away).

Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 7, 2024
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Jan 13, 2024
@GuardianDll
Copy link
Member Author

Closed in favor of #71306

@GuardianDll GuardianDll deleted the revert-69940-revert-69935-FOV_3D_on branch January 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants