Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more prosthetic-related issues #70024

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

MNG-cataclysm
Copy link
Contributor

Summary

Bugfixes "Replace psuedo-feet for prosthetic legs with proper prosthetic versions, and add infrastructure to block some effects prosthetics shouldn't get."

Purpose of change

Fix #69856's remaining issues.

Describe the solution

This PR does two things:

  1. Add proper prosthetic feet to go along with the prosthetic legs, getting rid of weird psuedo-limbs involved in that process. This is based off of the infrastructure for prosthetic hands.
  2. Using some workaround I found, add and EOC and some effects that prevent certain effects from appearing on prosthetic limbs, like deep bites, infection, poison, frostbite, and more. This keeps artificial limbs from being affected by things they shouldn't and makes them more realistic.

Describe alternatives you've considered

Not doing this, or adding a new field like the one Maleclypse suggested.

Testing

Went into the game and got beat up by a bunch of zombies, didn't get infected on any artificial limbs. Fought some spiders too, didn't get poisoned on any artificial limbs.

Additional context

I've been testing the limb healing effects for prosthetics, and they do indeed heal on their own. I'd need to implement some new C++ changes that gives a flag on artificial limbs that keep from healing, in a later PR probably.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing EOC: Effects On Condition Anything concerning Effects On Condition <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 6, 2023
@Maleclypse Maleclypse merged commit 0033431 into CleverRaven:master Dec 7, 2023
19 of 23 checks passed
@MNG-cataclysm MNG-cataclysm deleted the prosthetic_limb_fix branch December 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prosthetic Limb Issues
2 participants