Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] fix spells, that give temp limbs, take two #69464

Merged
merged 11 commits into from
Nov 17, 2023

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Nov 16, 2023

Summary

None

Purpose of change

It was revealed for me that previous fix #69298 was only a partial success, since effects was not able to remove itself in the end

Describe the solution

Change the spell again, now it is a toggleable spell that consume flat amount of mana, and recast itself each spell length time
To prevent player from giving their mana and time to cast a spell when turning off, new u_has_trait math function is used, made by Andrei8l (thank you again!)

Testing

Mutation is given to player, limbs appear and disappear as expected
I didn't compile the game to test new math function yet, will do it tomorrow-ish compiled the game, tested new math effect, looks good
image
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved <Bugfix> This is a fix for a bug (or closes open issue) labels Nov 16, 2023
@github-actions github-actions bot requested a review from Maleclypse November 16, 2023 22:21
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Nov 16, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 17, 2023
@Maleclypse Maleclypse merged commit abd89ee into CleverRaven:master Nov 17, 2023
21 of 26 checks passed
@GuardianDll GuardianDll deleted the limb_spells_part_two branch November 17, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants