-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Mound of Typo Fixes #68583
Merged
Maleclypse
merged 8 commits into
CleverRaven:master
from
detahramet:Typo-Fix-Part-2-Electric-Boogaloo
Oct 13, 2023
Merged
A Mound of Typo Fixes #68583
Maleclypse
merged 8 commits into
CleverRaven:master
from
detahramet:Typo-Fix-Part-2-Electric-Boogaloo
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Game: Achievements / Conducts / Scores
Player goals and how they are tracked.
Items: Armor / Clothing
Armor and clothing
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Innawood 🌲
Anything to do with Innawood mod
Mods: Xedra Evolved
Anything to do with Xedra Evolved
labels
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @GuardianDll @Light-Wave
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Oct 10, 2023
Fixes error with description length
Qrox
reviewed
Oct 10, 2023
data/mods/Xedra_Evolved/mutations/paraclesians/salamander_mutations.json
Outdated
Show resolved
Hide resolved
Thanks for taking this on, really appreciate the work. |
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
Sorry this has been stalled, I've been tied up with my weekend. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Oct 13, 2023
Closed
detahramet
added a commit
to detahramet/Cataclysm-DDA
that referenced
this pull request
Nov 6, 2023
* Fixed a Mound of Typos! * Non-Mound Related typo fixes. * Shortened No Leg Description Fixes error with description length * Update legs_prosthetics.json * Update legs_prosthetics.json * Apply suggestions from code review Co-authored-by: Jianxiang Wang (王健翔) <[email protected]> * Update data/mods/Xedra_Evolved/items/armor/integrated.json Co-authored-by: Jianxiang Wang (王健翔) <[email protected]> * Update salamander_mutations.json --------- Co-authored-by: Maleclypse <[email protected]> Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Game: Achievements / Conducts / Scores
Player goals and how they are tracked.
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Innawood 🌲
Anything to do with Innawood mod
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
As Issue #68497 states, there is a mound of typos, a solid chunk of which are mine.
Describe the solution
I have corrected the typos as per the afforementioned sadenar.
Describe alternatives you've considered
Being lazy and letting other people fix up my mess.
Testing
N/A
Additional context
Yeah, my bad on the typos.