Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some vehicle code from part indexes to part references pt2 #66816

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Migrate some vehicle code from part indexes to part references pt2 #66816

merged 5 commits into from
Jul 12, 2023

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Jul 11, 2023

Summary

None

Purpose of change

Continuation of #66796

Describe the solution

Make vehicle functions take part references

Describe alternatives you've considered

Testing

Same as linked issue, also crashed a vehicle a few times

Additional context

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 11, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 11, 2023
@dseguin dseguin merged commit 00ebda7 into CleverRaven:master Jul 12, 2023
@irwiss irwiss deleted the veh-cleanups-2 branch July 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irwiss @dseguin