Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some vehicle code from part indexes to part references #66796

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Jul 10, 2023

Summary

None

Purpose of change

Migrate some vehicle code from indexes into parts array to references

Describe the solution

Deletes a couple index-exclusive functions and moves the code using them to use part references instead

Describe alternatives you've considered

Testing

Tests should catch some of it
Manually drove around, installed/removed some parts

Additional context

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` Appliance/Power Grid Anything to do with appliances and power grid labels Jul 10, 2023
@irwiss irwiss changed the title Vehicle cleanups Migrate some vehicle code from part indexes to part references Jul 10, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 10, 2023
@dseguin dseguin merged commit 4ceb3e2 into CleverRaven:master Jul 11, 2023
@irwiss irwiss deleted the veh-cleanups-1 branch July 11, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants