Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Wielding a matrix crystal enhances your powers #66644

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "Wielding a matrix crystal enhances your powers"

Purpose of change

It's repeatedly stated in the Mind Over Matter lore that because pre-Catalcysm psionics were so weak, the only reason Project PHAVIAN really got anywhere with their research was the discovery of matrix crystals, which enhanced their users' powers by multiple orders of magnitude. I didn't want to go that far but I wanted them to do something other than cause a psionic awakening or be ground up for crafting.

Describe the solution

Using spell_level_adjustment, add a +4 spell level bonus when wielding (not just holding) a matrix crystal. This is a significant bonus and should make it a hard choice between using a matrix crystal to awaken vs keeping it and risking a portal storm and hoping for the same path, or keeping it vs using it in crafting (once recipes that require full matrix crystals are added).

As part of this PR, I also applied a specific JSON flag to each crystal and moved the draining process to be entirely EoC based rather than the crystals being SINGLE_USE

Describe alternatives you've considered

Testing

Used each crystal to awaken and held each crystal and checked the powers they enhanced, everything worked as intended. Changes are currently not as great as they should be due to #66641, but all the infrastructure will be there once that bug is fixed.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter labels Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This is a matrix crystal attuned to biokinesis.
  • This is a matrix crystal attuned to clairsentience.
  • This is a matrix crystal attuned to pyrokinesis.
  • This is a matrix crystal attuned to vitakinesis.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants