spell_level_adjustment does not account for spells whose traits are calculated using the math function

[Standing-Storm]

Describe the bug

Trying to make holding on to a matrix crystal enhance psionic powers the way Mind over Matter lore suggests it should. However, it looks like math only calculates based on the original level of the power, totally ignoring spell_level_adjustment.

Dev version of Mom:
MindOverMatter.zip

Attach save file

Roundup-trimmed.tar.gz

Steps to reproduce

1. Open the spellbook, notice range and damage on Fountain of Flames level 2
2. Wield a strange crystal, red
3. Open the spellbook, Fountain of Flames is now level 6 (+4) but the range and damage are the same.

Expected behavior

spell_level_adjustment and math properly work together

Screenshots

Power level 2:

Power level 6, holding crystal, same damage and range (casting time, which does not use the math function, is properly updated):

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.3086 (22H2)
• Game Version: 10875c2 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth],
  No Rail Stations [No_Rail_Stations],
  Mind Over Matter [mindovermatter]
  ]

Additional context

No response

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[andrei8l]

/confirmed but title is a backwards and this is not specifically a math problem

This line

Cataclysm-DDA/src/talker_character.cpp

Line 340 in 5eaa457

return me_chr_const->magic->get_spell( spell_name ).get_level();

should probably use get_effective_level() instead