Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No debug_mode when npc starts looping #66516

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Jun 28, 2023

Summary

None

Purpose of change

Fixes #51593
Stops players being confused https://discord.com/channels/598523535169945603/642349261320880128/1122867232532344933

Describe the solution

Debug mode shouldn't be player facing, remove the debug mode auto-toggle

Describe alternatives you've considered

Leaving the filter enabling code in, but all filters are already enabled by default

Testing

Don't think there's active reproduction case available, but the change is trivial and I crossed fingers on both hands

Additional context

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Jun 28, 2023
@NetSysFire NetSysFire added <Bugfix> This is a fix for a bug (or closes open issue) Code: Debug Debugging and troubleshooting the game, also includes the debug menu labels Jun 28, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 28, 2023
@dseguin dseguin merged commit 8699d06 into CleverRaven:master Jun 29, 2023
@irwiss irwiss deleted the stop-npcs-turning-on-debug branch June 29, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Debug Debugging and troubleshooting the game, also includes the debug menu json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game communicates achievement eligibility poorly when force-entering debug mode
3 participants