Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game communicates achievement eligibility poorly when force-entering debug mode #51593

Closed
Kribylet opened this issue Sep 13, 2021 · 1 comment · Fixed by #66516
Closed

Game communicates achievement eligibility poorly when force-entering debug mode #51593

Kribylet opened this issue Sep 13, 2021 · 1 comment · Fixed by #66516
Labels
<Bug> This needs to be fixed Code: Debug Debugging and troubleshooting the game, also includes the debug menu Game: Achievements / Conducts / Scores Player goals and how they are tracked. Good First Issue This is a good first issue for a new contributor Info / User Interface Game - player communication, menus, etc.

Comments

@Kribylet
Copy link
Contributor

Kribylet commented Sep 13, 2021

Describe the bug

I'm playing through C:DDA for the first time and have been having a mostly bug free time of it, so I've stayed off the debug menu for what small issues I've had because I wanted to see the little achievements chime in.

After I assigned an NPC to work at a faction camp, driving away and returning shortly afterwards, I was given a popup about an NPC caught in an infinite loop. That instantly enabled debug mode which I assume has now invalidated achievements (warning no longer pops up when attempting to toggle the debug menu). I wish it really hadn't.

The NPC was sleeping on a pile of logs it was presumably failing to chop into planks.

Reading #40292 it seems that any forced enabling of debug mode should either advertise that achievements have to be re-enabled for play mode or never disable them to begin with. Given that achievement disabling seems to be a development aid, advertising re-enabling seems the better option.

Steps To Reproduce

  1. Encounter NPC stuck in infinite loop
  2. Be forced into debug mode instantly
  3. Have achievements disabled for you for the rest of the game

Expected behavior

  1. Encounter NPC stuck in infinite loop
  2. Nothing

Alt.

  1. Encounter NPC stuck in infinite loop
  2. Be asked whether you would like to enter debug mode

Alt.

  1. Encounter NPC stuck in infinite loop
  2. Be forced into debug mode instantly
  3. Keep achievements enabled

Screenshots

No response

Versions and configuration

OS: Linux Mint
Version: 0.F-1 Frank-1
Graphics Version: Tiles
Ingame Language: English
Mods loaded: dda, no_npc_food, package_bionic_professions

Additional context

No response

@Kribylet
Copy link
Contributor Author

After seeing it was possible to re-enable achievements in the debug menu I tried and found out achievements were still enabled.

@Kribylet Kribylet changed the title NPC Detected in infinite loop instantly enters debug mode, disables achievements Game communicates achievement eligibility poorly when force-entering debug mode Sep 13, 2021
@actual-nh actual-nh added <Bug> This needs to be fixed Code: Debug Debugging and troubleshooting the game, also includes the debug menu Info / User Interface Game - player communication, menus, etc. Game: Achievements / Conducts / Scores Player goals and how they are tracked. labels Sep 14, 2021
@wapcaplet wapcaplet added the Good First Issue This is a good first issue for a new contributor label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Code: Debug Debugging and troubleshooting the game, also includes the debug menu Game: Achievements / Conducts / Scores Player goals and how they are tracked. Good First Issue This is a good first issue for a new contributor Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants