math_parser: evaluate variables in diag. functions #65467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Allow dialogue functions in
math
to evaluate their parameters from dialogue variables.So something like
can be fully ported to
where
myvar
gets evaluated insideu_skill
.Describe the solution
Expand the math parser to include this use case
TODO:
Describe alternatives you've considered
Third party parser
Testing
New test units
Additional context
This includes a tiny bit of code from #65465 so that the tests work.This will stay in draft until #65298 and #65465 get merged to spare myself some conflict resolution.