Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math_parser: port skill_level functions to math #65465

Merged
merged 1 commit into from
May 5, 2023
Merged

math_parser: port skill_level functions to math #65465

merged 1 commit into from
May 5, 2023

Conversation

andrei8l
Copy link
Contributor

@andrei8l andrei8l commented May 4, 2023 •
edited
Loading

Summary

None

Purpose of change

  • I need skill_level in math for npctrade: un-hardcode trade price formulas #65389 and I might as well port it from arithmetic since it has very few uses
  • Also port u_has_skill for consistency. There is a minor loss of functionality here - can't read skill id from variable anymore - but that's not used in JSON (and it's blocked by a minor bug) and I will address it in another PR momentarily.

Describe the solution

Port

Describe alternatives you've considered

Airport

Testing

Existing test unit

Additional context

N/A

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Armor / Clothing Armor and clothing Missions Quests and missions Mods Issues related to mods or modding Mods: Bombastic Perks Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Xedra Evolved Anything to do with Xedra Evolved NPC / Factions NPCs, AI, Speech, Factions, Ownership json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 4, 2023
@andrei8l andrei8l mentioned this pull request May 4, 2023
Merged
1 task
@andrei8l andrei8l force-pushed the math_parser-skill branch from a4edf23 to 25dc189 Compare May 4, 2023 10:00
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 4, 2023
@andrei8l andrei8l force-pushed the math_parser-skill branch from 25dc189 to 9cfa939 Compare May 5, 2023 03:20
@dseguin dseguin merged commit de43cc6 into CleverRaven:master May 5, 2023
@andrei8l andrei8l deleted the math_parser-skill branch May 5, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

@bombasticSlacks bombasticSlacks Awaiting requested review from bombasticSlacks

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Missions Quests and missions Mods: Bombastic Perks Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrei8l @dseguin