Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HEAVY WIP] Initial implementation of methane production #65413

Closed
wants to merge 11 commits into from

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented May 1, 2023

Summary

Content "Methane production chain"

Purpose of change

Methane production has been suggested a lot and @Drew4484 managed to fool me into doing this.

Describe the solution

For starters, adds a new furniture type - the biogas digester. It works kind of like a charcoal kiln except differently. The code, under the hood, is very similar. It takes in stuff made from specific materials (most common comestibles, dry plant, feces - the list currently is WIP and will likely be expanded) and processes them into methane. It also has a logic that, hopefully, excludes corpses from being put there because I don't want to deal with the process of having corpses leave behind bones or chitin.

In future commits I intend to add valves and inner tubes to make the construction recipe for the digester more inline with the real counterpart.

Describe alternatives you've considered

Testing

Okay now it should theoretically work but still don't get your hopes too high

Additional context

Huge thanks to @Drew4484 and @RenechCDDA for walking me through this because if I tried to do this all myself I'd probably cry

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Spawn Creatures, items, vehicles, locations appearing on map labels May 1, 2023
src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Show resolved Hide resolved
src/iexamine.cpp Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Build a biogas digester
  • Start the digester?
  • The batch in this digester is too small to yield anything useful.
  • The result of an interrupted methane production process. Useless, except as fuel in the biogas digester.
  • This digester already finished producing methane.
  • This digester contains %s %s of material, and the process is ready to be started.
  • This digester contains %s, which can't be used to produce methane!
  • This digester is empty. Fill it with organic matter and try again.
  • biogas digester
  • filled biogas digester

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 1, 2023
src/mapdata.cpp Outdated Show resolved Hide resolved
src/mapdata.cpp Outdated Show resolved Hide resolved
src/mapdata.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 1, 2023
@RenechCDDA
Copy link
Member

I am merely a humble contributor assisting others in copy pasting... I make no claims that I did anything good or useful here.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 1, 2023
@Karol1223 Karol1223 changed the title [HEAVY WIP] Methane Production initial implementation [HEAVY WIP] Initial implementation of methane production May 2, 2023
@Karol1223
Copy link
Contributor Author

Closing for now so that when I have time to finish this I can reopen this myself. If stalebot does it I have to bully people with merge rights again...

@Karol1223 Karol1223 closed this May 17, 2023
@Karol1223 Karol1223 reopened this Jul 7, 2023
@Karol1223
Copy link
Contributor Author

Somehow, the biogas returned

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Aug 8, 2023
@Karol1223
Copy link
Contributor Author

Well FINE, stalebot. Have it your way.

@Karol1223 Karol1223 closed this Aug 8, 2023
@Karol1223 Karol1223 reopened this Nov 30, 2023
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Nov 30, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 20, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 20, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 14, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Mar 27, 2024
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Mar 29, 2024
@kevingranade
Copy link
Member

Unless I'm missing something this isn't producing solid waste? Is that just not done yet or had you missed that facet of a bigoas digester?

@Karol1223
Copy link
Contributor Author

Unless I'm missing something this isn't producing solid waste? Is that just not done yet or had you missed that facet of a bigoas digester?

Honestly both. The code for this right now is a mess (the C++ currently does not work, because I just copied over the gas pump code to have it at hand). I intend to come back to this and first and foremost make some way to get the methane out of the digester, and after that make sure it matches realism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants