-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HEAVY WIP] Initial implementation of methane production #65413
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
I am merely a humble contributor assisting others in copy pasting... I make no claims that I did anything good or useful here. |
Closing for now so that when I have time to finish this I can reopen this myself. If stalebot does it I have to bully people with merge rights again... |
Somehow, the biogas returned |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Well FINE, stalebot. Have it your way. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
…the teacher won't be angry
I'll need to figure out how to merge the iexamine functions of this and the previous iexamine of the full biogas digester
Unless I'm missing something this isn't producing solid waste? Is that just not done yet or had you missed that facet of a bigoas digester? |
Honestly both. The code for this right now is a mess (the C++ currently does not work, because I just copied over the gas pump code to have it at hand). I intend to come back to this and first and foremost make some way to get the methane out of the digester, and after that make sure it matches realism. |
Summary
Content "Methane production chain"
Purpose of change
Methane production has been suggested a lot and @Drew4484 managed to fool me into doing this.
Describe the solution
For starters, adds a new furniture type - the biogas digester. It works kind of like a charcoal kiln except differently. The code, under the hood, is very similar. It takes in stuff made from specific materials (most common comestibles, dry plant, feces - the list currently is WIP and will likely be expanded) and processes them into methane. It also has a logic that, hopefully, excludes corpses from being put there because I don't want to deal with the process of having corpses leave behind bones or chitin.
In future commits I intend to add valves and inner tubes to make the construction recipe for the digester more inline with the real counterpart.
Describe alternatives you've considered
Testing
Okay now it should theoretically work but still don't get your hopes too high
Additional context
Huge thanks to @Drew4484 and @RenechCDDA for walking me through this because if I tried to do this all myself I'd probably cry