Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's technically possible to wield loose gasses #69920

Closed
Karol1223 opened this issue Dec 2, 2023 · 1 comment · Fixed by #69933
Closed

It's technically possible to wield loose gasses #69920

Karol1223 opened this issue Dec 2, 2023 · 1 comment · Fixed by #69933
Labels
Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Karol1223
Copy link
Contributor

Karol1223 commented Dec 2, 2023

Describe the bug

It is possible to wield loose gasses if they are in the overworld, despite not being to pick them up. Note that them being in the overworld is technically already an abnormal behavior - when dropped from being wielded they will disappear normally.

Attach save file

N/A, not without compiling an edited .exe

Steps to reproduce

  1. Compile [HEAVY WIP] Initial implementation of methane production #65413
  2. Get yourself a biogas digester
  3. Fill it up with some random organic garbage. Withered plants work
  4. Pass time
  5. Examine the digester - see that it now contains loose methane which is a gas
  6. The methane cannot be picked up, but pressing the keybind to wield it (default w I believe) will wield it regardless
  7. Drop it and see it disappear

Expected behavior

I guess I expect this not being possible but I am really not sure if this is a valid bug report given under normal circumstances gasses don't appear outside containers.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22621.2715 (22H2)
  • Game Version: 0.G-5550-g848c8bf3ec [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Standard combat test suite [standard_combat_test]
    ]

Additional context

I am not sure if this is a valid bug report, but it is causing me some headache in getting the aforementioned methane PR to be functional Edit: No, definitely valid. You can wield them out of containers this way.

@Karol1223 Karol1223 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 2, 2023
@mqrause
Copy link
Contributor

mqrause commented Dec 2, 2023

if( it.made_of( phase_id::LIQUID ) ) {
return ret_val<void>::make_failure( _( "You can't wield spilt liquids." ) );
}

Just needs another check like this for gases.

@NetSysFire NetSysFire added (S2 - Confirmed) Bug that's been confirmed to exist Items / Item Actions / Item Qualities Items and how they work and interact and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants