Fix to pollution by stat modifications in newcharacter.

[Wyghab]

Summary

Bugfixes "Fixes the situation where stat mods affect the displayed effects of your base stats."

Purpose of change

Fixes #64280

Describe the solution

avatar::reset_stats() is accumulating stat mods each passthrough because character::reset_bonuses() is never called on the object. reset_stats() should never be called without first resetting bonuses as it can reapply additional bonuses without clearing the last ones. Ideally character::reset() should be used in these situations? Regardless, I find that no mod bonuses should affect the displayed effects of your base stats, hence I've placed reset_bonuses() after reset_stats() so it only displays the effect of your base stats, though it could still be polluted by other means as I've not investigated the functions that calculate the bonuses that are affected by the stats.

Describe alternatives you've considered

Calling reset() instead of reset_stats() or extracting the calculations used to determine stat effects and calculate the bonuses in-place instead of relying on the avatar object.

Testing

Tested #64280, while also including the mutation "compound eyes" as that mutation will continually mod perception by 2 while equipped in the same manner as StatsThroughSkills or the BMI rework.

Additional context

This could likely need some refactoring later. Since this fix is closer to the core issue than #64270 , maybe the fixes from there can be removed safely. If there are other places in code that calls reset_stats() haphazardly it could cause issues in other places.

[github-actions]

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

[NetSysFire]

Feels like a good backport candidate.

[Wyghab]

Feels like a good backport candidate.

Just to keep the thread of change going for eventual refactor, this issue was caused by #57884. That PR assumed that using the avatar class to calculate everything and using reset_stats to update it to be less bug-prone, which seems untrue. So using the stat_max to calculate bonuses seem to be the way forward if what we want is for the stat panel to only care for your base stats when showing their effects.