Fix error with str/int/dex displaying weirdly during char creation #64270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Resolved stat display error during character creation"
Purpose of change
Fixes #64242
Describe the solution
Set stored kcal to an expected value when displaying places it could cause an error.
Describe alternatives you've considered
Do set_stored_kcal fewer times, some of the places it's added may be redundant.
Testing
Cloned and compiled. Confirmed that the issue no longer happens at any height amount. Then tried spawning a character with XXXL and confirmed they spawned at a morbidly obese kcal level despite their stored kcal repeatedly being set to a healthy value during character creation.
Additional context