Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make both Hub 01 modular defense ponchos' holster pocket compatible with all HWP conversion kits. #64084

Conversation

strategineer
Copy link
Contributor

@strategineer strategineer commented Mar 9, 2023

Summary

Bugfixes "Make both Hub 01 modular defense ponchos' holster pocket compatible with all HWP conversion kits."

Purpose of change

Making this change because being able to insert every kind of HWP conversion kit (robofac_gun_*) in the holster pocket of each poncho (robofac_armor_*) is the expected behavior.

Fixes #61357

Reproduction steps:

  1. Use the Debug Menu to spawn a HWP personal 5.7x28mm configuration (robofac_gun_57) and a HWP personal 4.6x30mm configuration (robofac_gun_46).
  2. Use the Debug Menu to spawn a Hub 01 modular defense anchor (robofac_armor_anchor) and a Hub 01 modular defense system (robofac_armor_rig).
  3. Wear both the defense anchor and defense system.
  4. Open your inventory, and try to insert HWP personal 5.7x28mm configuration into each system, notice that it doesn't show up as an option.
  5. Repeat step 4 with the HWP personal 4.6x30mm configuration and notice the same.

Describe the solution

Self-explanatory

Describe alternatives you've considered

None

Testing

Followed reproduction steps above and noticed that the bug was fixed!

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) labels Mar 9, 2023
data/json/items/armor/robofac_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/robofac_armor.json Outdated Show resolved Hide resolved
@strategineer strategineer changed the title Make both Hub 01 modular defense ponchos' holster pocket compatible with all HWP conversion kits. Make both Hub 01 modular defense ponchos' holster pocket compatible with all HWP configurations. Mar 9, 2023
…ith all HWP conversion kits.

Making this change because being able to insert every kind of HWP conversion kit (robofac_gun_*) in the holster pocket of each poncho (robofac_armor_*) is the expected behavior.

fixes CleverRaven#61357

Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@strategineer strategineer force-pushed the add_missing_hwp_to_hub_modular_defense_armors branch from a191db6 to 4d196f5 Compare March 9, 2023 21:44
@strategineer strategineer changed the title Make both Hub 01 modular defense ponchos' holster pocket compatible with all HWP configurations. Make both Hub 01 modular defense ponchos' holster pocket compatible with all HWP conversion kits. Mar 9, 2023
Copy link
Contributor

@bombasticSlacks bombasticSlacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 9, 2023
@John-Candlebury John-Candlebury merged commit ff5501c into CleverRaven:master Mar 10, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add two missing HWP conversion kits to both Hub 01 modular defense armors
3 participants