Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add two missing HWP conversion kits to both Hub 01 modular defense armors #61357

Closed
delta17pd opened this issue Sep 29, 2022 · 0 comments · Fixed by #64084
Closed
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON <Suggestion / Discussion> Talk it out before implementing

Comments

@delta17pd
Copy link

Is your feature request related to a problem? Please describe.

I've noticed that for both sets of Hub 01 Modular Defense armors, the pocket dedicated to storing "Hybrid Weapons Platform" quick-swap conversion kits (aka barrels) does not allow either the 5.7x28mm or 4.6x30mm configuration to be inserted, despite both of them being similar to the valid (9mm) personal defense configuration.

Solution you would like.

For both robofac_armor_rig and robofac_armor_anchor, add both robofac_gun_57 and robofac_gun_46 to the item_restriction arrays in the respective pocket_data sections (7th pocket down for both armors I believe).

Describe alternatives you have considered.

No response

Additional context

No response

@delta17pd delta17pd added the <Suggestion / Discussion> Talk it out before implementing label Sep 29, 2022
@Maleclypse Maleclypse added Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON labels Oct 3, 2022
strategineer added a commit to strategineer/Cataclysm-DDA that referenced this issue Mar 9, 2023
…th robofac_gun_57 and robofac_gun_46 HWP conversion kits

Make both Hub 01 modular defense armors' holster pocket compatible with robofac_gun_57 and robofac_gun_46 HWP conversion kits.

Making this change because this is the expected behavior (from what I can tell).

fixes CleverRaven#61357
strategineer added a commit to strategineer/Cataclysm-DDA that referenced this issue Mar 9, 2023
…th robofac_gun_57 and robofac_gun_46 HWP conversion kits.

Making this change because this is the expected behavior (from what I can tell).

fixes CleverRaven#61357
strategineer added a commit to strategineer/Cataclysm-DDA that referenced this issue Mar 9, 2023
…ith all HWP conversion kits.

Making this change because being able to insert every kind of HWP conversion kit (robofac_gun_*) in the holster pocket of each poncho (robofac_armor_*) is the expected behavior.

fixes CleverRaven#61357
strategineer added a commit to strategineer/Cataclysm-DDA that referenced this issue Mar 9, 2023
…ith all HWP conversion kits.

Making this change because being able to insert every kind of HWP conversion kit (robofac_gun_*) in the holster pocket of each poncho (robofac_armor_*) is the expected behavior.

fixes CleverRaven#61357

Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
2 participants