Fix "detect translation file changes" workflow #63731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Code: Tooling
github-actions
bot
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes the "detect translation file changes" workflow. Closes #59029.
Describe the solution
Use
pull_request_targetinstead ofpull_requestevent to run the workflow.Describe alternatives you've considered
Testing
Qrox#8 does not have the skip phrase so a comment was added automatically.
Qrox#9 has the skip phrase so no comment was added.
The changes in these PRs included a new line of logging code which was not executed in the respective workflows so the workflows were indeed run on the target branch instead of the PR branch, which means the workflows should not require approval for new contributers anymore.
Additional context