Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Detect translation file changes" workflow does not work #59029

Closed
Qrox opened this issue Jul 7, 2022 · 1 comment · Fixed by #63731
Closed

"Detect translation file changes" workflow does not work #59029

Qrox opened this issue Jul 7, 2022 · 1 comment · Fixed by #63731
Labels
Code: Tests Measurement, self-control, statistics, balancing. Organization General development organization issues

Comments

@Qrox
Copy link
Contributor

Qrox commented Jul 7, 2022

Describe the bug

See #59022, where the workflow gives an error saying Error: Unhandled error: HttpError: Resource not accessible by integration.

Also, since new contributors are most likely to modify the translation files, and the workflow needs to be approved for new contributers, it basically means the workflow won't work before someone with permission to approve workflows looks at the PR, which defeats the point of having a bot detect the unwanted changes.

Steps to reproduce

  1. Be a new contributor, make a PR modifying files in lang/po.
  2. The bot does not warn about the unwanted changes.

Expected behavior

The resource not accessible error should not happen, but I'm not sure what caused it.

Also, it would be nice to have this particular workflow run without approval, but it may introduce security vulnerabilities due to the bot's ability to post comments and it could be made to execute other malicious code.

Screenshots

No response

Versions and configuration

Not applicable

Additional context

No response

@Qrox Qrox added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jul 7, 2022
@BrettDong
Copy link
Member

A workflow triggered by a pull_request event runs in the head branch from the pull request author. It's an untrusted environment so the GitHub API token has read-only permission and cannot perform "write" activities like leaving a comment.

https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/

Pull requests from public forks are still considered a special case and will receive a read token regardless of these settings.

@BrettDong BrettDong added Organization General development organization issues Code: Tests Measurement, self-control, statistics, balancing. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Tests Measurement, self-control, statistics, balancing. Organization General development organization issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants