-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included new weather 'Rain Storm' and appropriate sound category. #59022
Conversation
Btw. I included new sections to all translation files, but I didn't include translations for those languages! |
Files in |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
…everRaven#59022) * Included new weather 'Rain Storm' and appropriate sound category. * Fixed a mistake and set "rains" to 'true'. * Fix my mess * Fix missing def Co-authored-by: L-3-on <[email protected]>
…everRaven#59022) * Included new weather 'Rain Storm' and appropriate sound category. * Fixed a mistake and set "rains" to 'true'. * Fix my mess * Fix missing def Co-authored-by: L-3-on <[email protected]>
Summary
Content "Includes new type of weather 'Rain Storm' and sound category therefor"
Purpose of change
Adds a weather type similar to "Snowstorm" with a condition of windpower >= 15 but a temperature >= 33. Also integrating a separate sound category "rainstorm" it would be possible to improve sound packs with special audio file for that situations where there's a gale blowing and it's pouring.
Describe the solution
I searched the source files for all references of "Thunder", "WEATHER_THUNDER" and "outdoors_thunderstorm_env". After that, I took the following steps:
Describe alternatives you've considered
Testing
Well, tbh. I have a bit of programing knowledge but never worked with C++ and MS Visual Studio so I simply couldn't figure out how to compile the source files. I therefore testetd the changes only the new weather type without a special audio channel definition: I included the "rainstorm" definition in "weather_type.json" and the new weather type to the "regional_map_settings.json". Those got loaded in the current experimental db8eb88 (tiles) without any problems and got used ingame without errors.
Additional context