Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe fix for some mild steel weapons #63547

Merged
merged 1 commit into from Feb 13, 2023
Merged

Recipe fix for some mild steel weapons #63547

merged 1 commit into from Feb 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2023

Summary

Bugfixes "Fix hammering requirement on some mild steel weapon recipes"

Purpose of change

some mild steel weapon recipes had hammering 4 instead of hammering 3

Describe the solution

Hammering quality requirement adjusted from 4 to 3 on:
mild steel estoc
mild steel jian
mild steel wakizashi
mild steel scimitar
mild steel longsword
mild steel rapier

Describe alternatives you've considered

Testing

checked the recipes and everything was correct

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Feb 11, 2023
@NetSysFire NetSysFire added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Feb 11, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 12, 2023
@cake-pie
Copy link
Contributor

Those values were set in #60574 and may have been intentional, we should ask @Drew4484.

@Drew4484
Copy link
Contributor

Those values were set in #60574 and may have been intentional, we should ask @Drew4484.

Change away! Those were probably copy-paste errors from other weapons I added.

@dseguin dseguin merged commit b1ead3e into CleverRaven:master Feb 13, 2023
@ghost ghost deleted the recipe-fix-for-some-mild-steel-weapons branch February 13, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants