Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graded steel weapon recipes #60574

Merged
merged 44 commits into from
Sep 14, 2022

Conversation

Drew4484
Copy link
Contributor

@Drew4484 Drew4484 commented Aug 29, 2022

Summary

Content "Graded Steel Recipes"

Purpose of change

Adds recipes to make graded steel weapons. The requirements for making better weapons also require additional materials to make durable nonconductive grips.

Describe the solution

Add new nested recipes for each grade of steel. Allow existing weapons to 'upgrade' to tempered steel.

Recipes

  • Arming Sword
  • Broadsword
  • Cavalry Sabre
  • Cutlass
  • Estoc- 2x grip material
  • Falx - 2x grip material
  • Jian
  • Katana - 2x grip material
  • Kriegsmesser
  • Longsword
  • Nodachi - 2x grip material
  • Rapier
  • Scimitar
  • Wakizashi
  • Zweihänder - 2x grip material
  • Obsolete original recipes
  • Figure out nesting
  • Replace spawnlist versions

Describe alternatives you've considered

None

Testing

WIP

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 29, 2022
@ANickelN
Copy link
Contributor

What does the 2x grip material indicate? Two different kinds of items you could use for the grips? Would they be separate recipes or the same?

@Drew4484
Copy link
Contributor Author

What does the 2x grip material indicate? Two different kinds of items you could use for the grips? Would they be separate recipes or the same?

Two handed grips, it's more of a note to myself to increase the materials needed. Each of the weapons has three levels of grip: mild steel has no grip and only uses the 'solid' grip modifier, the medium and high steel use leather and wire wrapped grips for a 'weapon' grip modifier that also is nonconductive (wire is wrapped around the non-conductive leather, if done properly would protect the user), and the hardened and tempered grip uses kevlar and epoxy as a molded durable grip that remains nonconductive.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map and removed json-styled JSON lint passed, label assigned by github actions labels Sep 9, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Recipes for making jians.
  • Recipes for making katanas.
  • Recipes for making nodachis.
  • Recipes for making wakizashis.
  • jians
  • nodachis
  • wakizashis

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Sep 13, 2022
@Drew4484 Drew4484 force-pushed the Steel-grade-weapon-recipes branch from 078f253 to bda2f3d Compare September 13, 2022 18:38
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 13, 2022
@Drew4484 Drew4484 marked this pull request as ready for review September 13, 2022 21:21
@github-actions github-actions bot added Items: Armor / Clothing Armor and clothing and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 13, 2022
@Drew4484 Drew4484 force-pushed the Steel-grade-weapon-recipes branch from 8698643 to 8e76843 Compare September 13, 2022 23:25
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 13, 2022
@dseguin dseguin merged commit 913d296 into CleverRaven:master Sep 14, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 14, 2022
@Drew4484 Drew4484 deleted the Steel-grade-weapon-recipes branch June 20, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants