Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City exclusives, rural exclusives #63511

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

Content "City exclusives, rural exclusives"

Purpose of change

Removes stuff that don't belong in cities, migrates the ones that do & vice versa.
Partially addresses #62747.

Describe the solution

  • removed ponds from cities — we have better things to put into cities than wilderness ponds.
  • migrated nature trails from rural spawns to cities — started to look a wee bit outdated once forest trails were added, repurposed as urban forestry.
  • removed public ponds, fishing ponds, small warehouses from rural spawns — sidewalks looked a bit jarring outside of cities (as mentioned in Roads don't generate sensibly around gas stations #59482); but worry not, I do intend to replace them with bigger, more rural-fitted locations pretty soon™.

Describe alternatives you've considered

Not removing stuff.

Testing

Game loads without errors. Noticed a lack of ponds and an increase in nature trails in cities.

Additional context

kép

ponds removed from cities, nature trails migrated to cities, removed small warehouses & fishing ponds from rural spawns
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 9, 2023
@ZhilkinSerg ZhilkinSerg merged commit a521814 into CleverRaven:master Mar 2, 2023
@LovamKicsiGazsii LovamKicsiGazsii deleted the special-to-city branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants