Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check error originating from TALK_lumbermill_fabricate.json #63102

Merged
merged 6 commits into from
Jan 14, 2023

Conversation

MNG-cataclysm
Copy link
Contributor

Summary

Bugfixes "Fix the check error coming from TALK_lumbermill_fabricate.json"

Purpose of change

As pointed out here, a check error has originated in this file due to changes made to the trade system. This should fix it.

Describe the solution

Added brackets around the effect entries in trade dialogue.

Describe alternatives you've considered

None.

Testing

This PR should test it. If the error doesn't appear in the tests, it will be fixed.

Additional context

None.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 13, 2023
@Maleclypse
Copy link
Member

Exception when parsing JSON data type "effect_on_condition"
Error in JSON file: 'data/json/npcs/lumbermill_employees/TALK_lumbermill_fabricate.json'
'effect'
Error in extracting strings from JSON. Aborting.
Error: Process completed with exit code 1.```

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 13, 2023
…json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Jan 13, 2023
@dseguin
Copy link
Member

dseguin commented Jan 14, 2023

You can undo the other changes if you want. The only fix here is to add the blank "effect" field.

Don't worry about the Text Changes Analyzer failure on the base commit, the merge commit is what matters here.

Screenshot from 2023-01-13 19-50-58

@MNG-cataclysm
Copy link
Contributor Author

You can undo the other changes if you want. The only fix here is to add the blank "effect" field.

Don't worry about the Text Changes Analyzer failure on the base commit, the merge commit is what matters here.

Screenshot from 2023-01-13 19-50-58

Personally, I think the change should be left as-is, just to cover all the bases.

@dseguin dseguin merged commit 7c3a129 into CleverRaven:master Jan 14, 2023
@MNG-cataclysm MNG-cataclysm deleted the lumbermill_effects branch January 14, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants