Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix a transactional error with the lumbermill trader"
Purpose of change
Like the chemist trader (#63064), the lumbermill trader had a bug in which purchase options would become unavailable if the player could not pay for them, as though they had bought the merchandise.
Describe the solution
Like the chemist, I moved the cooldown timer application to a true-false EOC, defined in the
u_buy_item
effect.Describe alternatives you've considered
This is the alternative, mainly for #62804.
Testing
Went to a lumbermill, tried to buy some logs, and exited the trade menu when I couldn't afford it. The option remained available for purchase, and I successfully bought them later with some valuables. I repeated this with the other options that have cooldown timers.
Additional context
None.