Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the lumbermill trader #63084

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

MNG-cataclysm
Copy link
Contributor

Summary

Bugfixes "Fix a transactional error with the lumbermill trader"

Purpose of change

Like the chemist trader (#63064), the lumbermill trader had a bug in which purchase options would become unavailable if the player could not pay for them, as though they had bought the merchandise.

Describe the solution

Like the chemist, I moved the cooldown timer application to a true-false EOC, defined in the u_buy_item effect.

Describe alternatives you've considered

This is the alternative, mainly for #62804.

Testing

Went to a lumbermill, tried to buy some logs, and exited the trade menu when I couldn't afford it. The option remained available for purchase, and I successfully bought them later with some valuables. I repeated this with the other options that have cooldown timers.

Additional context

None.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 12, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 12, 2023
@Fris0uman Fris0uman merged commit 1542f97 into CleverRaven:master Jan 13, 2023
@cake-pie
Copy link
Contributor

An issue in data/json/npcs/lumbermill_employees/TALK_lumbermill_fabricate.json that probably originates from here seems to be causing Text Changes Analyzer checks to fail across multiple PRs that are completely unrelated to that file. (example)

> Extracting strings from JSON
Exception when parsing JSON data type "effect_on_condition"
Error in JSON file: 'data/json/npcs/lumbermill_employees/TALK_lumbermill_fabricate.json'
'effect'
Error in extracting strings from JSON. Aborting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants