-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic finales for generic mine #62688
Merged
bombasticSlacks
merged 8 commits into
CleverRaven:master
from
Night-Pryanik:generic-finale-4-generic-mine
Mar 5, 2023
Merged
Generic finales for generic mine #62688
bombasticSlacks
merged 8 commits into
CleverRaven:master
from
Night-Pryanik:generic-finale-4-generic-mine
Mar 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
labels
Dec 11, 2022
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Dec 11, 2022
MNG-cataclysm
approved these changes
Dec 12, 2022
Co-authored-by: MNG-cataclysm <[email protected]>
…ght-Pryanik/Cataclysm-DDA into generic-finale-4-generic-mine
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Dec 14, 2022
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Dec 14, 2022
MNG-cataclysm
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Generic finales for generic mine"
Purpose of change
Add more "generic" finales for generic mine, as it was discussed in #56555.
Describe the solution
feral archaeologist
monster and its death drops list. Its description sucks, to be honest, but I can't invent something more interesting.breather hub
monster with an artifact beneath it.Describe alternatives you've considered
None.
Testing
Debug-spawned mine finales dozens of times, checked if everything is ok.
Additional context
"True generic" variant
"Archaeology" variant
"Trencher" variant
"Breather" variant