Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic finales for generic mine #62688

Merged
merged 8 commits into from
Mar 5, 2023
Merged

Generic finales for generic mine #62688

merged 8 commits into from
Mar 5, 2023

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Content "Generic finales for generic mine"

Purpose of change

Add more "generic" finales for generic mine, as it was discussed in #56555.

Describe the solution

  • Added feral archaeologist monster and its death drops list. Its description sucks, to be honest, but I can't invent something more interesting.
  • Added 4 new "generic" finales for generic mine:
    • "True generic" variant (100 weight): just a dead end with a bunch of zombie miners, some miners' gear and minerals;
    • "Archaeology" variant (40 weight): essentially a rework of my own "archaeology" variant for cave mapgen from Cave jsonify #39610, but with new feral archaeologists, their gear and two crates with some potentially interesting archaeology loot in them, including spiral and vortex stones;
    • "Trencher" variant (50 weight): again, just a bunch of zombie miners with gear, minerals and working trencher (representing some mining machine);
    • "Breather" variant (30 weight): a breather hub monster with an artifact beneath it.
  • The old "The Thing" finale is still here, but is given rather low weight for spawning (30).

Describe alternatives you've considered

None.

Testing

Debug-spawned mine finales dozens of times, checked if everything is ok.

Additional context

"True generic" variant
изображение

"Archaeology" variant
изображение

"Trencher" variant
изображение

"Breather" variant
изображение

@Night-Pryanik Night-Pryanik added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Dec 11, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 11, 2022
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Dec 14, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 14, 2022
@bombasticSlacks bombasticSlacks merged commit f186be3 into CleverRaven:master Mar 5, 2023
@Night-Pryanik Night-Pryanik deleted the generic-finale-4-generic-mine branch March 5, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants