Vahallist member no longer spawn as random npcs #62533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
MNG-cataclysm
approved these changes
Dec 2, 2022
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
According to @MNG-cataclysm, they didn't intend on making the vahallist members spawns as random npc. So I'm fixing it.
Describe the solution
Give
"common": falsein both the vahallist member's npc_class and vahallist shopkeeper's npc_class.Describe alternatives you've considered
Letting the vahallist member spawn as random npcs but they would need their own npc_class for it.
Testing
If the doc is right, adding
"common": falseshould made them not spawn as random npcs.Additional context
Thank you @MNG-cataclysm for the info and approval.