Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] fix blood as fuel stuff #62327

Merged

Conversation

MrDraMaster
Copy link
Contributor

Summary

Mods "[Magiclysm] Fix follow-up stuff from blood volume changes"

Purpose of change

The Blood Power Generator CBM's tank allows default, human and tainted blood, but it currently can't fit a single unit of those. Then I found more blood-volume related inconsistencies...

Fixes #54030
Fixes #56765
I think this closes #45040

Describe the solution

  • container volume was 100ml (with a max item volume of 32ml), so I increased that proportionally to handle a max item volume of 250ml (aka 750ml container volume)
  • also found that the "human blood" material did not have an energy value, so (mutant) human blood would be burned for 0 Joules even though it's a listed fuel of the CBM, so I gave it the same fuel_data as basic blood
  • the "Scroll of Acide Resistance" recipe and the "Decaying Boneclub" spell components still values for the old 1 ml volume for tainted blood (that makes the Boneclub spell waste 50 ml of tainted blood, but that doesn't seem so bad in comparison to requiring 500 liters previously...)

Describe alternatives you've considered

Testing

  1. Debug in the CBM, some bionic power storage, and samples of the various blood types
  2. reload the tank with a blood type, activate the CBM, walk around, and see the bionic power go up
  3. repeat step 2 with another blood type
  • debug-learn the "Decaying Boneclub" spell, open spellcasting menu, see that "Decaying Boneclub" now requires a reasonable 1 unit of tainted blood
  • debug all recipes, check "Scroll of Acid Resistance", see that it now requires a reasonable 8 units of tainted blood

Additional context

dragon_blood still has a unit volume of 1 ml, not the (now) usual 250 ml of all the other blood types, but changing that seemed like it'd get weird with all those glass flask > dragon blood (250) presumedly lying around. (Also would have made its use in the Decaying Boneclub spell way overpriced.)
This also made me realise that the Blood Draw Kit can only get 1 ml of the stuff since iuse::blood_draw doesn't care about volume, it always adds a single blood unit and is then considered full. As I don't have a C++ setup (yet), that's definitely out of my range.

mana_infused_blood currently can not be used as fuel for the CBM but maybe should, but that seems out of scope for this PR (and I have no idea how many kJ it should burn for).

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) Mechanics: Enchantments / Spells Enchantments and spells Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 21, 2022
@Fris0uman Fris0uman merged commit 98195f1 into CleverRaven:master Dec 1, 2022
@MrDraMaster MrDraMaster deleted the magiclysm/fix-blood-as-fuel-stuff branch December 1, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
2 participants