-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Blood Power Generator CBM using charges instead of volume #45040
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Can I ask how you determined it's using charges instead of volume? I've been trying to debug this but I the code trail for bionics that use ammo seems excessively knotted |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
The blood generator still requires 25L of blood. |
Note: the CBM currently does not accept human blood (id: blood) (see #54030) so I used animal blood (id: animal_blood) instead. This is what I see after putting 250ml of animal blood into the CBM:
|
Describe the bug
Blood power generator CMB does not measure the volume of blood it contains, but instead treats blood as charges, with each charge being 0.25L (250mL) which is well beyond what the item's description states being its maximum capacity, that being 100mL. This works out to requiring 25L of blood to fill the generator. Simple math, I know, but I just had to type that out because it's absurd enough to be funny.
Steps To Reproduce
Expected behavior
A 250mL flask should be able to refill the CBM's storage two and a half times, but that just isn't the case. I'm not sure how this could be done, but, with its current description, the generator should be treating each mL of blood as a charge.
Perhaps its efficiency could be increased and its capacity changed to one or two litres? As it stands, this generator is not worth using whatsoever.
"dda",
"no_npc_food",
"package_bionic_professions",
"secronom",
"aftershock",
"Arcana",
"blazeindustries",
"crt_expansion",
"magiclysm",
"XEAS",
"DinoMod",
"Cata++",
"Mining_Mod",
"more_survivor_stuff",
"MMA",
"Chibi_Ultica",
"Graphical_Overmap",
"Graphical_Overmap_Magiclysm",
"speedydex",
"stats_through_kills"
The text was updated successfully, but these errors were encountered: