Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Blood Power Generator CBM using charges instead of volume #45040

Closed
Arkaile opened this issue Oct 24, 2020 · 5 comments · Fixed by #62327
Closed

[Magiclysm] Blood Power Generator CBM using charges instead of volume #45040

Arkaile opened this issue Oct 24, 2020 · 5 comments · Fixed by #62327
Labels
Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed Mods: Magiclysm Anything to do with the Magiclysm mod (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Arkaile
Copy link

Arkaile commented Oct 24, 2020

Describe the bug

Blood power generator CMB does not measure the volume of blood it contains, but instead treats blood as charges, with each charge being 0.25L (250mL) which is well beyond what the item's description states being its maximum capacity, that being 100mL. This works out to requiring 25L of blood to fill the generator. Simple math, I know, but I just had to type that out because it's absurd enough to be funny.

Steps To Reproduce

  1. Install blood power generator CBM and a power storage CBM.
  2. Spawn a flask of human blood. It should contain 0.25L of blood.
  3. Consume it and see how many charges it added to the CBM. From my experience, it should only add one charge.

Expected behavior

A 250mL flask should be able to refill the CBM's storage two and a half times, but that just isn't the case. I'm not sure how this could be done, but, with its current description, the generator should be treating each mL of blood as a charge.

Perhaps its efficiency could be increased and its capacity changed to one or two litres? As it stands, this generator is not worth using whatsoever.

  • OS: Windows 10
  • Game Version: 0.E-7041-gdb7d137 [64-bit]
  • Graphics version: Tiles
  • Ingame language: English
  • Mods loaded:
    "dda",
    "no_npc_food",
    "package_bionic_professions",
    "secronom",
    "aftershock",
    "Arcana",
    "blazeindustries",
    "crt_expansion",
    "magiclysm",
    "XEAS",
    "DinoMod",
    "Cata++",
    "Mining_Mod",
    "more_survivor_stuff",
    "MMA",
    "Chibi_Ultica",
    "Graphical_Overmap",
    "Graphical_Overmap_Magiclysm",
    "speedydex",
    "stats_through_kills"
@wapcaplet wapcaplet added Bionics CBM (Compact Bionic Modules) Mods: Magiclysm Anything to do with the Magiclysm mod labels Oct 31, 2020
@stale
Copy link

stale bot commented Dec 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 5, 2020
@Xpyder
Copy link
Contributor

Xpyder commented Jun 27, 2021

Can I ask how you determined it's using charges instead of volume? I've been trying to debug this but I the code trail for bionics that use ammo seems excessively knotted

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jun 27, 2021
@stale
Copy link

stale bot commented Jul 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jul 29, 2021
@anothersimulacrum anothersimulacrum added (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed and removed stale Closed for lack of activity, but still valid. labels Sep 15, 2021
@anothersimulacrum
Copy link
Member

The blood generator still requires 25L of blood.

@hexagonrecursion
Copy link
Contributor

Note: the CBM currently does not accept human blood (id: blood) (see #54030) so I used animal blood (id: animal_blood) instead.

This is what I see after putting 250ml of animal blood into the CBM:

DeepinScreenshot_select-area_20220104145753

  • OS: Linux
    • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 34 (Thirty Four); Release: 34; Codename: ThirtyFour;
  • Game Version: eacb7d9 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm]
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed Mods: Magiclysm Anything to do with the Magiclysm mod (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants