Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable butchering of very heavy corpses #62326

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Nov 21, 2022

Summary

Bugfixes "Enable butchering of very heavy corpses"

Purpose of change

Related to #44508
Items can already overflow to nearby tiles if there's no more space. However butchering could create items with large amounts of charges that are over 1000 liter big and thus can't be placed anywhere.

Describe the solution

Split up stacks so they end up as multiple items that don't exceed 1000 liter.

Describe alternatives you've considered

Removing charges would also fix this. (Soon™)

Testing

Set Alamosaurus to 70 tons and butchered it. Got myself 30k chunks of meat and literally tons of other stuff. That almost filled up the overflow range, I'd estimate the actual limit will be at around 100 tons (with some variability) at which point stuff will be deleted again because it can't overflow anymore.

Additional context

Still no support for larger corpses. Doing that would mean actual work and have design implications and stuff.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 21, 2022
@mqrause mqrause force-pushed the split_butcher_stacks branch from 5e17019 to 8877b66 Compare November 21, 2022 20:22
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 21, 2022
@dseguin dseguin merged commit e9c0942 into CleverRaven:master Nov 23, 2022
@mqrause mqrause deleted the split_butcher_stacks branch November 23, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants