inv_ui: fix category toggle of disabled entries

[andrei8l]

Summary

None

Purpose of change

Disabled entries in inventory UIs can be selected in category mode
Fixes: #62221

Describe the solution

Enforce the selected/highlighted distinction a little better

Describe alternatives you've considered

N/A

Testing

Trade with Rubik, turn on category selection mode, then highlight and select a CBM. The rejected CBMs shouldn't be highlighted or selected
Highlight one of the rejected CBMs and try again

Additional context

N/A

[Ilysen]

This PR appears to have introduced a CTD that happens whenever you attempt to wield or wear an item from the Pickup menu that you can't fit into your inventory. The issue doesn't happen if the changes to inventory_ui.cpp are reverted back to the old version. Stacktrace and whatnot coming in a linked issue.

[Wishbringer]

Managed to fix the crash I was having when trying to select liquids by changing this line:

--- a/src/inventory_ui.cpp
+++ b/src/inventory_ui.cpp
@@ -1047,7 +1047,7 @@ inventory_entry &inventory_column::get_highlighted()
 std::vector<inventory_entry *> inventory_column::get_all_selected() const
 {
     const auto filter_to_selected = [&]( const inventory_entry & entry ) {
-        return is_selected( entry );
+        return is_highlighted( entry );
     };
     return get_entries( filter_to_selected );
 }
-- 

Not sure if that is the correct way to fix it, but I'll run with it for now (hopefully doesn't break the functionality of this PR?).

[andrei8l]

Managed to fix the crash I was having when trying to select liquids by changing this line:

--- a/src/inventory_ui.cpp
+++ b/src/inventory_ui.cpp
@@ -1047,7 +1047,7 @@ inventory_entry &inventory_column::get_highlighted()
 std::vector<inventory_entry *> inventory_column::get_all_selected() const
 {
     const auto filter_to_selected = [&]( const inventory_entry & entry ) {
-        return is_selected( entry );
+        return is_highlighted( entry );
     };
     return get_entries( filter_to_selected );
 }
-- 

Not sure if that is the correct way to fix it, but I'll run with it for now (hopefully doesn't break the functionality of this PR?).

That basically reverts half of this PR. Please open a bug report for the issue you're having with all the relevant info (save file, crash log, config folder) as there's probably a specific combination I'm missing.