Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kord's spawn is more predictable #62206

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Kord's spawn is more predictable #62206

merged 3 commits into from
Nov 14, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Kord's spawn is more predictable"

Purpose of change

Describe the solution

Added MISSION_ITEM flag to Kord to make its spawn independent from world's item spawn scaling factor. Added documentation for this flag.

Describe alternatives you've considered

None.

Testing

Set world's item spawn scaling factor to 0.01. Debug-spawned gun_show OMS about a dozen times to check that Kord's spawn is guaranteed.

Additional context

None.

@Night-Pryanik Night-Pryanik added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Missions Quests and missions Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Nov 13, 2022
@github-actions github-actions bot added [Markdown] Markdown issues and PRs <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 13, 2022
@dseguin dseguin merged commit 46172a3 into CleverRaven:master Nov 14, 2022
@Night-Pryanik Night-Pryanik deleted the kord-is-a-mission-item branch November 14, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) <Documentation> Design documents, internal info, guides and help. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Missions Quests and missions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kord did not spawn (Guaranteed items not guaranteed on lower item spawn scaling factor?)
2 participants
@Night-Pryanik @dseguin