Fix vehicle zones not invalidating on move

[irwiss]

Summary

None

Purpose of change

Fixes #55091

Describe the solution

Rebuild vehicle zones after vehicles move

Describe alternatives you've considered

Testing

Scenario in linked issue

Additional context

[Fris0uman]

Does rebuilding the zone after every move have any performance impact?

[irwiss]

It probably does but not in a perceivable way.

It's hard to catch the function in profiler since it's too fast to produce reliable samples, but it's possible to do a naive measurement using high_resolution_clock, replace the call at map.cpp:598 with

    const auto t1 = std::chrono::high_resolution_clock::now();
    // refresh vehicle zones for moved vehicles
    zone_manager::get_manager().cache_vzones( this );
    const auto t2 = std::chrono::high_resolution_clock::now();
    const std::chrono::duration<int64_t, std::nano> ns = t2 - t1;
    add_msg( "cache_vzones in vehmove took %d ns", ns.count() );

add #include <chrono> on top

It measures around 20000ns for no vehicles moving or around 190000ns (0.19 millisec) for moving vehicle with 100 bound zones

Don't think there's much to optimize in vehicle movement here, worst case autodrive is ever so slightly slower.

There is a spot to optimize - the zone_manager::cache_vzones() itself, it is called from all over the place including per-turn activities and is super weird; It calls map::get_vehicle_zones which then calls zone_manager::cache_vzones() once more for some weird reason

But that's a bigger change than a small fix