Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Riot Armor to modern armor standards #62048

Merged
merged 24 commits into from
Nov 24, 2022

Conversation

bean-b
Copy link
Contributor

@bean-b bean-b commented Nov 1, 2022

Summary

Content "Updated Riot Armor to modern armor standards."

Purpose of change

The old riot armor made little sense, 55%/60% coverage all around, 1000g of weight, and as such was not up to modern armor standards and made little sense. Therefore, I updated the armor values to make more sense.

Describe the solution

The materials are now plastic padding and thermoplastic resin for protection. The suit has varying protection values across it, as i tried to base the material thicknesses off of current riot armors. It also has a small amount of molle webbing(on the thighs) as i saw that that was common across many riot suits.

Describe alternatives you've considered

The riot arm/shin guards are very similar to the hard leg/arm guards and thus may be a bit confusing. Also any of the values could be changed of course. Currently it isnt repairable which im not sure is ideal, but that is because thermoplastic resin and plastic padding are not repairable, which seems out of the scope of this pr.

Testing

Spawned the item in game, saw defensive values, tested attaching and detaching molle.

Additional context

Designed after this suit vaguely after:
https://www.securityprousa.com/collections/riot-gear/products/damascus-gear-modular-hard-shell-crowd-control-suit

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 1, 2022
@Jarewill
Copy link
Contributor

Jarewill commented Nov 1, 2022

Since the armor now incorporates a jumpsuit, maybe it should also be on the normal layer alongside the outer layer as well as be padded/comfortable?

@bean-b
Copy link
Contributor Author

bean-b commented Nov 1, 2022

I'm pretty sure its already padded/comfortable given the materials within. But I could totatly make it normal + outer if that makes more sense given its components and that it sorta has a normal layer built in. Another option would be to model it after a version without the nylon jumpsuit underneath, i.e. https://www.securityprousa.com/collections/riot-gear/products/secpro-riot-suit-1
I saw about half and half of both styles of designs when I was researching, and so I think this could go either way.

@bean-b
Copy link
Contributor Author

bean-b commented Nov 1, 2022

I guess my main question with making it have both layers is what the difference between this vs say the track touring suit is. The track touring suit has an entire 1.3mm leather jumpsuit that holds all of the plastic padding etc, but only occupies the outer layer.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 2, 2022
@nopenoperson
Copy link
Contributor

break up all the hard plastic into multiple pieces in a way that makes sense. like shin guards (could have foot guards, knee pads that could be modular), groin protector ( with hip protection?) chest protector (with protection for shoulders and upper arm? protective foam vest could be separate piece worn on normal layer), forearm protectors (with built in elbow pads or might be separate?) etc.

having it be a single article of clothing makes no sense.

@bean-b
Copy link
Contributor Author

bean-b commented Nov 2, 2022

Yea i can do that

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing and removed json-styled JSON lint passed, label assigned by github actions labels Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • pair of riot arm guardss
  • pair of riot leg guardss

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 2, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 2, 2022
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 2, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 2, 2022
@anoobindisguise
Copy link
Contributor

Only thing I could think to change is to bump up the plastic padding thickness a little. Other uses of plastic padding have 12-14mm.

@bean-b
Copy link
Contributor Author

bean-b commented Nov 2, 2022

Is there anything particularly wrong with less thick plastic padding layers? I know many of the motorcycle armors have a lottt of plastic padding, but I don't see any reason against having less on another piece of armor. I chose the plastic padding material because most riot suit advertise shock absorbing foam tm or something along those lines, although the thicknesses didint seem insane as it was all underneath the thermoplastic resin. Would there be a sort of halway point of like 6-8mm? Because 12+mm would more then double armor values and probably increase encumbrance values as well.

@anoobindisguise
Copy link
Contributor

Is there anything particularly wrong with less thick plastic padding layers? I know many of the motorcycle armors have a lottt of plastic padding, but I don't see any reason against having less on another piece of armor. I chose the plastic padding material because most riot suit advertise shock absorbing foam tm or something along those lines, although the thicknesses didint seem insane as it was all underneath the thermoplastic resin. Would there be a sort of halway point of like 6-8mm? Because 12+mm would more then double armor values and probably increase encumbrance values as well.

There's absolutely a right number there that likely isn't 2mm or 12mm. Just depends on the design specs of RL armors.

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 2, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 3, 2022
@bean-b
Copy link
Contributor Author

bean-b commented Nov 7, 2022

@TheShadowFerret Could you review this when you get the chance? Thanks so much. Also if there is a better way to request reviews please let me know.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Nov 8, 2022
@bean-b
Copy link
Contributor Author

bean-b commented Nov 9, 2022

or @MNG-cataclysm if you could review that would be great!

@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Nov 16, 2022
data/json/items/armor/legs_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/torso_armor.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Nov 16, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 16, 2022
@I-am-Erk I-am-Erk merged commit 72ce753 into CleverRaven:master Nov 24, 2022
@bean-b bean-b mentioned this pull request Nov 26, 2022
@bean-b bean-b deleted the riot-armor branch December 9, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants