Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: give labeler workflow write permissions #61988

Closed
wants to merge 1 commit into from

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

see #61981 (comment) so the labeler ain't working due to missing permissions, best case scenario we just need to add them manually to the workflow; this pr adds them that would make some sense, but I don't trust github so much, I am gonna give it an honest shot

this should be all we need https://github.com/actions/labeler#create-workflow

Describe the solution

let it read the contents of prs (it already did that) and write to prs

    permissions:
      contents: read
      pull-requests: write

Describe alternatives you've considered

Testing

this pr, maybe - github I hate that this works on my fork, just cause it's my fork

so like I need at least another person to test for real, for real

or maybe another account for testing permission stuff?

Additional context

gonna revert everything if this still ins't working, this #61946 and #61904

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 28, 2022
@casswedson
Copy link
Contributor Author

oh well

https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/3349130284/jobs/5548856805 the file there has the permissions set up
doesn't work at all, I guess I could look into updating the action's code some other time, for now let's just revert this baby

@casswedson casswedson closed this Oct 28, 2022
@casswedson casswedson deleted the hope-mild-hurdle branch October 28, 2022 23:37
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant