Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto labeler maintenance #61904

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

  1. and the main reason to make this pr https://discord.com/channels/598523535169945603/598535827169083403/1034224363861450812 your wish is my command; don't label changes to the spell checker dictionary file as Code: Tooling

  2. make most keyword searches use '**keyword**' instead on some variant of the previous but with a / somewhere, something something not very tidy

  3. make directory searches actual directory searches data/mods/Aftershock/**/* would mean directories inside the afs directory, just use bla/Aftershock/**

Describe the solution

Describe alternatives you've considered

Testing

docs here https://github.com/actions/labeler#common-examples ackually kinda hard to figure out

casswedson#60
the timeline is a little messy at the end thanks to the 3rd commit being timestamped before the label removal, the label gets applied right after because the test ran after the removal; it works I promise

Additional context

1. and the main reason to make this pr
https://discord.com/channels/598523535169945603/598535827169083403/1034224363861450812
your wish is my command; don't label changes to the spell checker
dictionary file as `Code: Tooling`

2. make most keyword searches use `'**keyword**'` instead on some variant
of the previous but with a `/` somewhere, something something not very tidy

3. make directory searches actual directory searches
`data/mods/Aftershock/**/*` would mean directories inside the afs
directory, just use `bla/Aftershock/**`
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 24, 2022
@dseguin dseguin merged commit 5e36b1a into CleverRaven:master Oct 25, 2022
@casswedson casswedson deleted the dic-inst-tools branch October 25, 2022 23:51
casswedson added a commit to casswedson/Cataclysm-DDA that referenced this pull request Oct 28, 2022
casswedson added a commit to casswedson/Cataclysm-DDA that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants