Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand merchant storage space #61877

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

MNG-cataclysm
Copy link
Contributor

@MNG-cataclysm MNG-cataclysm commented Oct 23, 2022

Summary

Bugfixes "Give merchants greater pocket space for buying things"

Purpose of change

Some stationary merchants could only buy items within their pocket size, despite having shelves and crates for storage. I've added the proper zones to allow stationary merchants to buy large, bulky items. PR #59805 is a good example of the methods I used.

Describe the solution

I gave several NPCs the shopkeeping mission status and added unsorted and currency loot zones to their shops.

Describe alternatives you've considered

Giving the merchants larger storage clothing, such as giant novelty backpacks or more duffel bags.

Testing

I spawned a character, teleported around, and sold 10L bricks of aluminum to various people. They all accepted the trade, and put the ingots to the side.

Additional context

This will fix issues #61530 and #58604. Additionally, wait timers have been made NPC-specific for lumber merchants and chemists.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 23, 2022
@PatrikLundell
Copy link
Contributor

Have you tested that it still works when the location maps are rotated? There's otherwise a risk the zones end up being fixed regardless of the rotation of the trader location.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 23, 2022
@MNG-cataclysm
Copy link
Contributor Author

Have you tested that it still works when the location maps are rotated? There's otherwise a risk the zones end up being fixed regardless of the rotation of the trader location.

I tested it, and the zones rotate with the map.

@Rivet-the-Zombie Rivet-the-Zombie merged commit ad6cafc into CleverRaven:master Oct 26, 2022
@MNG-cataclysm MNG-cataclysm deleted the merchant_pockets branch October 27, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants