Scrap Trader Inventory Expansion and QoL Update

[Merikona]

Summary

Features "Scrap trader now sells bronze and aluminum and is no longer limited by pocket size when trading"

Purpose of change

I made an issue a couple days ago, here #59749, because I realized that it made little sense that someone who is sedentary is restricted by their pocket size when trading, and furthermore, that there should be plenty of metals beyond steel that he should have access to in a scrap yard.

Edit: I didn't realize at the time of making this PR that spoiler ahead some specialty metals are locked behind a quest-chain. This means I'll have to revise a bit of my intended changes. I still want to add bronze and aluminum though.

Describe the solution

Allows scrap trader to accept larger volume items and gives 2 additional dialogue options for buying aluminum and bronze when trading. I consulted some real-world pricing for various metals here, https://rockawayrecycling.com/scrap-metal-prices/, but ultimately determined that the pricing would change for a post-apocalyptic scenario. e.g. bronze would be higher-valued than copper because it's more durable and can be reforged into armor.

Edit: Also changes to the mapgen, including a tow truck and shed.

Describe alternatives you've considered

Considered adding wood to the scrap trader's inventory as well since it made sense to me he'd have plenty of access to scrap wood, but figured I'll wait on that bit and maybe ask for feedback first.

Testing

Created a world and character in my branched version of CDDA. Teleported to a scrap trader. Traded him a log in exchange for his goods to test his volume limits. Used the three new dialogue options to obtain scrap aluminum, scrap copper, and bronze.

Additional context

[Merikona]

Ran into a curious problem testing. Items you trade to scrapper do not disappear over time. I've found a solution but have yet to implement it. Going to rework this NPC to have a weekly stock as well when I do. So marked as draft for now. To be continued.

[MNG-cataclysm]

I don't think the scrap trader should sell wood; the lumber merchants already do that.

[Merikona]

I don't think the scrap trader should sell wood; the lumber merchants already do that.

Sounds good. I'll rein it in then.

[Kywi001]

Additional on the #59749
The pocket size issue also exists on all trader in the location, such as the nurse and doctor, both won't accept even Merch due to them having 0 pocket size, I had to debug equip them with duffel bags so that they would accept the trade.

[Merikona]

Additional on the #59749 The pocket size issue also exists on all trader in the location, such as the nurse and doctor, both won't accept even Merch due to them having 0 pocket size, I had to debug equip them with duffel bags so that they would accept the trade.

I can take a look at this as well.

[Merikona]

Whew, took me a while to get this done, but I think it's finally ready. Learned a fair bit about mapgen and npcs on the way.

If there's a way to set explicit trade zones, please let me know. For some reason, items in the fridge 2 tiles away from the scrapper is still in the trade menu, so I had to make them specifically not for sale.

A tow truck spawns here 100% of the time in perfect condition with a good amount of gas. I've removed items that generate inside the truck and placed them indoors instead so players can't easily steal them. There's even a chance for a town map to spawn. To make sure the players can't abuse our poor scrapper by driving his car away, I've made it so 4 of the 6 wheels are removed and sitting in his office instead. Unfortunately, I don't think he will react if you sneak up to his car and siphon some gas. But try touching any of his belongings and you'll have a few homemade grenades chucked your way and maybe eat a few bullets from his AR15. Nobody gets to bully my NPCs!

But feel free to stay the night in the cozy shed, do missions for him, and trade with him.

[andrei8l]

Instead of blocking the fridge items, just make the loot zones not cover the fridge. One of your loot zones is over a wall and out of range too. You can verify the placements with debug mode (action menu->debug->toggle debug mode, then open the zone manager and change Faction).

[Merikona]

Why is it problematic? It's just there for flavor.

Edit: I actually think narcolepsy would be the more problematic one, if there was a problematic trait. I wasn't sure if it would make the scrapper sometimes doze off while you're trying to talk to him, so you couldn't trade with him. Or if him dozing off meant you could take his stuff for free.

[MNG-cataclysm]

You should probably mention that this PR will fix issue #61295.