Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Big Sur-style macOS icons #61738

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

Leland
Copy link
Contributor

@Leland Leland commented Oct 16, 2022

Summary

Build "Add Big Sur-style macOS icons"

Purpose of change

I updated our macOS icons to higher quality resolutions in #23181, back in 2018. Since then, macOS has landed on "squircle" icons, and leaves vertical whitespace. CDDA's older icon caused it to really sit out of place in the dock as a result.

This PR adds such a backing to the macOS CDDA app icons. The sizes are all generated with our SVG, so they're crisp.

Describe the solution

N/A

Describe alternatives you've considered

N/A

Testing

N/A

Additional context

Before:
Screenshot 2022-10-16 at 10 34 12 AM

After:
Screenshot 2022-10-16 at 10 30 40 AM

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 16, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 16, 2022
@Leland
Copy link
Contributor Author

Leland commented Oct 16, 2022

Failing test looks fine...? I guess this is just flaky:

([slow] ~starting_items)=> ??:?
([slow] ~starting_items)=> Catch::RunContext::runTest(Catch::TestCase const&)
([slow] ~starting_items)=> ??:?
([slow] ~starting_items)=> Backtrace emission took 2 seconds.
([slow] ~starting_items)=> (continued from above) ERROR : src/item.cpp:1500 [ret_val item::put_in(const item&, item_pocket::pocket_type, bool)] tried to put an item (thermos) count (1) in a container (daypack) that cannot contain it: pockets unacceptable because item is too short, item too big, or not enough space27.572 s: shot_features

@dseguin dseguin merged commit 3d0c70a into CleverRaven:master Oct 17, 2022
@Leland Leland deleted the minor/add-icn branch October 18, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants