Add new Mac ICN sizes #23181
Merged
Add new Mac ICN sizes #23181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG located at data/xdg/cataclysm-dda.svg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our old Mac icon only existed in a 128px x 128px resolution. Mac icons expect, however, 16, 32, 64, 128, 256, 512, and 1024px resolutions from icons.
This PR uses the git-tracked SVG icon to generate all of those resolutions and creates the appropriate icon for it.
In other words, the Mac version of CDDA will now have a sexy non-pixellated app icon 🙂
After / Before
I additionally passed the logo SVG through SVGO, which performs non-destructive simplification of the markup