-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert CLIMATE_CONTROL to enchantments and simplify effect #61139
Convert CLIMATE_CONTROL to enchantments and simplify effect #61139
Conversation
b06c1a8
to
907f165
Compare
I'd much prefer if climate control's power costs went up with the temperature difference. Though I guess that might be out of scope for this PR. |
907f165
to
1b82e22
Compare
Looks like this would fix the climate control problem in #59657 (might even resolve the issue) |
This will make climate control work in extreme cold but the effect won't be strong enough for an exosuit - it's equivalent to ambient temperature changing by 25C/45F. Ideally this would be adjustable for every source of the effect but I'm not sure how to do that. Make it an enchantment? |
I'm going to go ahead and JSON-ify climate control while I'm at it. |
e5f6dd1
to
b3222e4
Compare
35d0ee9
to
d293b79
Compare
d293b79
to
0d7e5a5
Compare
0d7e5a5
to
4a17022
Compare
4a17022
to
223fdb7
Compare
223fdb7
to
94072d7
Compare
Summary
Balance "Climate Control CBM (and equivalent effects) now works more consistently, doesn't completely shut down in extreme temperatures, and can stack"
Purpose of change
CLIMATE_CONTROL has some problems:
Describe the solution
Climate control is now a pair of enchantments, controlling the heating and chilling ability respectively. They simply move body temperature towards normal by up to a fixed value. For now I set it to 50 everywhere, which is close to the previous performance of climate control, and most sources received equal heating and cooling. Exceptions are some Aftershock items that are explicitly for protection against cold and those only have heating.
Describe alternatives you've considered
Testing
Checked:
Climate control on exosuit underlayers doesn't work due to #59657, but they have the definitions and should work once that's fixed.
Additional context
Remaining problems that will require more substantial changes to address: