Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Attunements... again.. #61005

Merged
merged 19 commits into from
Oct 26, 2022
Merged

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Sep 14, 2022

Summary

Mods "Adding even more attunement effects"

Purpose of change

There is a lot of stuff that must be added to attunements.

Describe the solution

Some of stuff still require work to dehardcode them, but bunch of stuff were doable using pure json

BOREAL_MAGE - got passive AoE field, that deal cold damage around, and permanent +9 cold damage in melee, and CLIMATE_CONTROL flag
GLACIER_MAGE - got passive small AoE field, that deal bash damage, and effect, that can knockback enemies in melee (it also must inflict downed status, but it doesnt work currently) (knockback itself is also buggy shit, my huge apologize to glacier players), and CLIMATE_CONTROL flag
VULCANIST - got a CLIMATE_CONTROL flag
MAGNETISM_MAGE - got some bullet damage resistance, and SIGHT_RANGE_ELECTRIC, which allow him to feel electric creatures (Thank you Irwiss!), and ELECTRIC_IMMUNE flag
TUNDRA_MAGE - got passive slowdown DoT field, and CLIMATE_CONTROL flag
ICE_ELEMENTAL - got +9 cold damage in melee
CLEANSING_FLAME - got a CLIMATE_CONTROL flag
FIRE_ELEMENTAL - got a CLIMATE_CONTROL flag
STORMCALLER - got ELECTRIC_IMMUNE flag
STORM_ELEMENTAL - got ELECTRIC_IMMUNE flag
GAIAS_CHOSEN - got +30% to hp buff
EARTH_ELEMENTAL - got ELECTRIC_IMMUNE flag
PERMAFROST_MAGE - got effect that substract moves from monster that try to attack user, and a CLIMATE_CONTROL flag
SOULFIRE - got +9 pure damage in melee
SUN_MAGE - got CLIMATE_CONTROL flag
RADIATION_MAGE - got small AoE, that emit clairvoyance
ILLUSIONIST - got some social boosts
GOLEMANCER - got an ability to block minor damage monsters attack with 1/5 chance (kinda)
GRAVITY_MAGE - slightly edited his effects, added 2 new spells (accidentally, i planned to make it in separate PR, but shit happened) - gravity leap, which is a huge jump, and tactile telekinesis, which buff your melee
SHAMAN - got +40% to mana regen
WITHER_MAGE - got AoE DoT bioligical field, that damage monsters nearby, and spell, that gives small stat boosts when you fight in melee (also added +15 armor penetration using ITEM_DAMAGE_AP, but it doesnt work currently)
BLOOD_MAGE - got ability to heal himself for a bit when attack in melee

yeah, most temperature related attunements got CLIMATE_CONTROL, and all electric related got ELECTRIC_IMMUNE, because it feels odd to be a frozen mage and be vurnerable to cold temperatue

All AoE effects were moved to separate mutations (including existing one) to be able to turn them off (partially to prevent #55397, partially for perfomance wins when player make long term activities), and are given by using weird EoC

Testing

Seems good for me, but of course i can miss something

Additional context

Current status of attunements (imo) (aka what was left to do):

VULCANIST - 1 passive effect
ARTIFICER - 1 passive effect
TUNDRA_MAGE - 1 passive effect
CLEANSING_FLAME - 2 passive effects
STORMCALLER - 2 spells, 2 passive effects
STORM_ELEMENTAL - 1 spell, 1 passive effect
VOID_MAGE - 1 passive effect
PERMAFROST_MAGE - 1 spell, 1 passive effect
RADIATION_MAGE - 1 passive effect
FORCE_MAGE - 1 passive effect
ALCHEMIST - 2 passive effects
ILLUSIONIST - 1 spell, 1 passive effect

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 14, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • AoE cold attack around the player. If you are seeing this spell, you have debugged it in.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 14, 2022
@Dan1ss1mo
Copy link
Contributor

Doesnt Force mage already have 2 passive eddects: 20% speed bost and double melee damage?

@GuardianDll
Copy link
Member Author

Doesnt Force mage already have 2 passive eddects: 20% speed bost and double melee damage?

image

@Dan1ss1mo
Copy link
Contributor

Doesnt Force mage already have 2 passive eddects: 20% speed bost and double melee damage?

image

seems like some one like forcemage a bit too much)) Graeat work btw)

@GuardianDll
Copy link
Member Author

GuardianDll commented Sep 14, 2022

No, i just think having flat bonuses is boring. Id be glad to add some new passive stuffs for all attunements, but some of them would have been even more OP, and i want to see them in more or less equal level of coolness
maybe i really need to left force mage as it is
or i decrease his stats (😈) if ill find something cool and related to his powers

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 18, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 19, 2022
@GuardianDll
Copy link
Member Author

GuardianDll commented Sep 26, 2022

deleted soul pressure and mind reading passive effect messages, because whats the reason if they require activations from now

@Light-Wave
Copy link
Contributor

You might wanna check out #61139 if you haven't already

@GuardianDll
Copy link
Member Author

yeah, ive seen that one, just didnt know it was merged already
but thanks for notify, ill fix the merge conflicts tomorrow

@Fris0uman Fris0uman merged commit 4723891 into CleverRaven:master Oct 26, 2022
@GuardianDll GuardianDll deleted the attunements branch October 30, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants