More misc vehicle menu fixes #61025
Merged
More misc vehicle menu fixes #61025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
NetSysFire
added
Info / User Interface
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Make controlled vehicle menu offer examine menu item to match muscle memory before #60868
Describe the solution
Enable the menu item when controlling vehicle
Also slight cleanups;
Merge
vehicle::start_folding_activityto call site - trivial, used twice before, only one call left and not much reuse potentialRemove
vehicle::is_open- unused in game code, only in tests, adjusts tests to usevehicle_part::openDescribe alternatives you've considered
Testing
^ twice on controls tile - should see examine/remember vehicle menu items
Test suite should pass using vehicle_part::open
Additional context